samlify icon indicating copy to clipboard operation
samlify copied to clipboard

fix: base url extraction in case its an object or string array

Open Tomer-L opened this issue 11 months ago • 3 comments

the problem is that buildRedirectURL function can receive baseUrl of type 'object' (returned from the function getSingleSignOnService)

The “url” argument must be of type string. Received an instance of Object

I ran into this issue myself when integrating with jumpcloud as IDP, after some online research I found out this solution https://community.n8n.io/t/n8n-enterprise-sso-configuration-jumpcloud/65861/11 Beside of the support for object type I added support for the case that baseUrl is []string since the function getAssertionConsumerService may return it

Tested and it solved my problem.

Tomer-L avatar Mar 24 '25 15:03 Tomer-L

This might fix: #405 #308 #328 CC @tngan

Tomer-L avatar Mar 25 '25 13:03 Tomer-L

bump @tngan 👀?

Tomer-L avatar May 07 '25 10:05 Tomer-L

Trying 5 months later @tngan 🙏

Tomer-L avatar Aug 25 '25 09:08 Tomer-L