googleplay_dev_scraper icon indicating copy to clipboard operation
googleplay_dev_scraper copied to clipboard
verified publisher icon tmurakam

better handling for application statistics

Open shao1555 opened this issue 12 years ago • 6 comments

in current version, application statistics always returns as zipped CSV file. so I've make some modification to this library.

  • retrieve CSV file, extract it (if need), then returns merged "ApplicationStatistics" model.
  • add find / select features for collections of ApplicationStatistics
  • write configuration in any context (like aws/aws-sdk-ruby)
  • to reliable spec test, use WebMock instead of your custom mock class.

sorry for my poor code and english.

shao1555 avatar Dec 19 '13 13:12 shao1555

no one is assigned?

shao1555 avatar Dec 29 '13 13:12 shao1555

Thanks. Your pull request was merged to features/application-statistics-model branch. (Not yet merged to develop / master branch).

Whould you like to update ChangeLog file?

tmurakam avatar Dec 29 '13 14:12 tmurakam

thank you for your reviewing.

I've added ChangeLog file. but I don't know rules for version number in this project, so place version number to "x.x.x" . please update version number in ChangeLog and change gemspec file after merge this.

shao1555 avatar Dec 30 '13 02:12 shao1555

please merge it or give me some suggestion.

shao1555 avatar Jan 20 '14 13:01 shao1555

Merged to features/application-statistics-model branch.

tmurakam avatar Jan 20 '14 13:01 tmurakam

I inspected your code, and found some issues.

  1. Your code does not work for HTTP proxy environments. You must set configuration BEFORE call Scraper.new, because proxy configuration is read only when constructor of Scraper is called.

  2. You changed config and agent to singleton, but I think this is not necessary change and I dislike this.

tmurakam avatar Jan 20 '14 14:01 tmurakam