dargon2 icon indicating copy to clipboard operation
dargon2 copied to clipboard

Fix the build problems in issue 22 related to FFI

Open dan-at-confirm opened this issue 1 year ago • 4 comments

Issue: https://github.com/tmthecoder/dargon2/issues/22

This PR is being opened on behalf of @qui-jason.

It seems there was an upgrade to the ffi plugin that requires a minor change.

dan-at-confirm avatar Mar 12 '24 14:03 dan-at-confirm

Didn't realize this branch was associated with a PR, sorry about that. FWIW I tried to make the arm64 runner work with android tests and kept running into this issue: https://github.com/actions/runner-images/issues/9472#issuecomment-1984324388 which is why there are so many commits.

Tests are passing, I'll squash some stuff.

qui-jason avatar Mar 18 '24 12:03 qui-jason

Flutter tests pass after upgrading some of the CI toolchain, but the top level workflow is commented out at the moment.

qui-jason avatar Mar 18 '24 12:03 qui-jason

@tmthecoder how does this look to you?

dan-at-confirm avatar Mar 18 '24 14:03 dan-at-confirm

I fixed the top level tests as well, but I used a deprecation override to do so. The correct solution (required for Dart 3.4) is to use isolates, I believe.

Screenshot 2024-03-19 at 3 54 41 AM

qui-jason avatar Mar 19 '24 06:03 qui-jason