tmpolaczyk

Results 112 comments of tmpolaczyk

The changes in `impl TryFrom for RadonString` are problematic because they cannot be made conditional using TAPI (there is no way to pass an extra argument to try_from), and it's...

Looking great! I found some unexpected changes in the StringMatch operator: basically if the default value is a string, the result of the match is now converted to a string....

Importing a different master key is not supported because the node will not index old transactions to the new address. For example: * Send 1 wit to the new address...

`owning_ref` is a dependency of `async-jsonrpc-client`, which is a legacy package that we use in some projects. The `async-jsonrpc-client` package has many outdated dependencies like futures 0.1, which forces us...

The priority command should always output the estimated time in seconds/minutes instead of epochs, we can't expect users to know if 10 epochs is fast or slow.

I tried to make some unit tests and the estimates are a bit strange, I would expect the fees to always be sorted in order such that stinky < low...

This is the output I get on mainnet with commit 4fde7cb6c41b2c469d696e31eb3060084197041a ``` ╔══════════════════════════════════════════════════════════╗ ║ TRANSACTION PRIORITY ESTIMATION REPORT ║ ╠══════════════════════════════════════════════════════════╣ ║ Data request transactions ║ ╟──────────┬──────────┬────────────────────────────────────║ ║ Tier │ Priority...

Also I don't see any way to encode the information that the block still has room for more transactions. Because when blocks are almost empty (1 or 2 transactions per...

I'm wondering if it would be better UX to fix the estimated time to the most common values (for example, 1 minute, 1 hour, 1 day), and then calculate the...