time_difference icon indicating copy to clipboard operation
time_difference copied to clipboard

ActiveSupport >=5.1 Support

Open jmortlock opened this issue 6 years ago • 9 comments

Adds support for active support 6, whilst maintaining compatibility with active support 5 and older ruby versions.

jmortlock avatar Nov 30 '19 00:11 jmortlock

Did you see the #45?

AlexWayfer avatar Nov 30 '19 01:11 AlexWayfer

Did you see the #45?

Yes I did, the end result of this PR is the same (allow this Gem to be used in Rails 6 projects) however it maintains support with older rails / rubies which seem to be the main objections to merging the referenced PR

jmortlock avatar Nov 30 '19 02:11 jmortlock

@tmlee This project still maintained?

jmortlock avatar Dec 01 '19 04:12 jmortlock

@tmlee This project still maintained?

You can switch to the replace_activesupport_with_tardis_and_dry branch of my fork, if you wish.

AlexWayfer avatar Feb 02 '20 20:02 AlexWayfer

@tmlee This project still maintained?

Yes i will update this gem soon to support newer version of Rails

tmlee avatar Feb 03 '20 01:02 tmlee

@tmlee Please, that would be great!

c2ofh avatar Feb 06 '20 20:02 c2ofh

I've chosen this version of code to be used.

kalashnikovisme avatar Mar 07 '21 21:03 kalashnikovisme

I've chosen this version of code to be used.

Thank you for let us knowing!

AlexWayfer avatar Mar 12 '21 17:03 AlexWayfer

To make it easier for those wishing to use @jmortlock's fork that adds Rails 6 support, you can use this in your Gemfile:

gem "time_difference",                          # Simple TimeDifference operations. NOTE: We use this fork to support Rails 6: https://github.com/tmlee/time_difference/pull/48
    github: "jmortlock/time_difference",
    ref:    "74cfe3fdbf2a50dd80d7c0fdf457bf2b9384edd6"

This locks it to that specific git commit as well to avoid any surprises with bundle update, should the master branch see any further commits.

joshuapinter avatar Aug 18 '22 22:08 joshuapinter