langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

ollama: internal client is no more up to date

Open treywelsh opened this issue 1 year ago • 2 comments

The ollamaclient package is no more up to date. We should remove it and use directly the official ollama client. The Ollama API is also described here

There's probably a lot more but here's what I've noted so far:

  • Some options are no more up to date:
    • UseNuma is removed by https://github.com/ollama/ollama/pull/6186
    • NumGQA, RopeFrequencyBase, RopeFrequencyScale are removed by https://github.com/ollama/ollama/pull/1983
    • EmbeddingOnly is removed by https://github.com/ollama/ollama/pull/2848
  • There's now a second embeddings endpoint. The documentation say it supersede the older one.

I would like to be assigned to this issue in order to make a PR for this ASAP.

By the way, when looking at older issues about the ollama client in langchaingo it seems there's a bit of cleaning to do, for instance this issue has been solved but is still opened: https://github.com/tmc/langchaingo/issues/778

treywelsh avatar Sep 24 '24 12:09 treywelsh

It's really great, when can I use it

pdxrlj avatar Sep 29 '24 01:09 pdxrlj

I made small tests, it seems to works. Feel free to give it a try on the development branch

treywelsh avatar Sep 30 '24 08:09 treywelsh