d2modmaker icon indicating copy to clipboard operation
d2modmaker copied to clipboard

Randomizer produces junk lines in UniqueItems.txt

Open BardurArantsson opened this issue 5 years ago • 2 comments

(I see that a rework is planned before v1.0, so apologies if this is already planned to be fixed by that rework. I thought it best to report it just in case.)

Some lines in UniqueItems.txt are actually just section headings, e.g. search for 'Expansion' or 'Class Specific', where the only filled-in data fields are the 'index' and the 'eol' column.

Running the v0.5.0 randomizer erroneously fills in the prop columns on these rows too. It doesn't seem to confuse the game itself, but it could lead to some properties being (effectively) removed from the game when running with the Balanced option.

(I suspect, but haven't confirmed that the same happens to items which are disabled, e.g. the 'enabled' column = 0, see e.g. Constricting Ring.)

BardurArantsson avatar Aug 14 '20 09:08 BardurArantsson

The main randomizer rework is already complete, but this bug won't cause any issues with props being removed. The properties can be used more than once, so randomizing extra items, or things that aren't items doesn't "use up" those props.

I think I can still fix this pretty easily. It can be done at the same time the quest items are fixed.

Deadlock39 avatar Aug 14 '20 13:08 Deadlock39

Generator is smart enough not to do this. Checks the lvl column I believe.

OldBeardedCoder avatar Jan 12 '21 17:01 OldBeardedCoder