d2modmaker icon indicating copy to clipboard operation
d2modmaker copied to clipboard
verified publisher icon tlentz

Randomizing functionality for Gems.txt

Open Sveet opened this issue 5 years ago • 2 comments

Hey there, thanks for reviewing the PR

This is not intended to be accepted as-is. Please leave any feedback or improvements you see.

TODO (will update):

  • [ ] Feature toggles in main config
  • [x] Shuffle gems by tier (not color) (config option)
  • [ ] Prevent random from picking vanilla mods (config option)

Sveet avatar Aug 13 '20 02:08 Sveet

Hi thanks for the PR, I have not had the time to review it. maybe @Deadlock39 @Wraithulek or @OldBeardedCoder could take a look?

tlentz avatar Nov 11 '20 16:11 tlentz

Have you looked at the new Scorer module I've been baking for the last month & a half? I believe it might make sense to generate all new properties for gems and runes instead of just swapping them. It makes sense to me to use PropScores to score the affixes in Gems.txt, then roll for properties in PropScores.txt that match the score within a certain percentage. This would allow you the possibility of getting affixes like blah% chance to cast level blah fireball. I do have a question though, does modifying Gems.txt affect already socketed items?

OldBeardedCoder avatar Dec 19 '20 05:12 OldBeardedCoder