react-native-audio-streaming icon indicating copy to clipboard operation
react-native-audio-streaming copied to clipboard

Making getStatus into a promise (ios)

Open mg173 opened this issue 9 years ago • 1 comments

Would you consider making the getStatus bridge function (https://github.com/tlenclos/react-native-audio-streaming/blob/master/ios/ReactNativeAudioStreaming.m#L175) return a promise instead of accepting a callback?

Or alternatively, to avoid a breaking api change make a new function with identical functionality which returns a promise?

Happy to submit a pull request if you're interested.

Reactnative reference: https://facebook.github.io/react-native/docs/native-modules-ios.html#promises

mg173 avatar Jan 08 '17 15:01 mg173

mayankgupta173 great idea, because for now this feature is useless

Arkanine avatar Jan 27 '17 18:01 Arkanine