Tanguy Krotoff comments

Results 84 comments of


                                            Tanguy Krotoff

What use cases is this intended to support?

> > `Intl.LocaleMatcher.match(navigator.languages, ["fr", "en", "de"], "en");` > yes that's the primary use case we're proposing to support. @longlho Then why Intl.LocaleMatcher.match requestedLocales doesn't take (also) a string? Do we...

Simplify the npm package files

> What chunk format would you consider more friendly? No chunks > tsup I've never used tsup nor needed it for my libraries, maybe it's not a great tool, maybe...

Server functions silently return undefined when response Content-Type is not RSC

> @Laecherlich > [...] > `return NextResponse.next({ headers: requestHeaders, request: { headers: requestHeaders, }, });` > [...] Without setting the headers it works perfectly. In my opinion the proper solution...

Toggle between modals makes the backdrop too dark

I don't think this is worth fixing

Fix OpenAPI required fields

Yes I plan to work on it I'm just missing time :-/

Fix OpenAPI required fields

@alexandrebodin OK, hope v5 solves this issue

chore: document slug using JSDoc

I prefer a review than a stupid bot that automatically closes PR

chore: version field in docker-compose.yml files is obsolete

I prefer a review than a stupid bot that automatically closes PR

Fix docker compose command in documentation and examples

I prefer a review than a stupid bot that automatically closes PR

chore: rename React component props type from Args to Props

I prefer a review than a stupid bot that automatically closes PR