scipdf_parser icon indicating copy to clipboard operation
scipdf_parser copied to clipboard

Refactorings and adding pydantic

Open skuam opened this issue 2 years ago • 1 comments

Hey, I found your project and that was exactly what I needed, but it rather crude form and the overall quality of code seemed not satisfactory to me. So I fixed up the code and made it a bit more clear and general. Overall functionality remains unchanged. Mainly, I changed the way you call to do it through class, so there is no global GLOBIT variable and it is more configurable and put all flying dictionaries with data into proper Pydantic classes, so it is easier for any application to ingest the data. Feel free to either disregard this pull request or merge it if you like the changes.

skuam avatar Jul 09 '23 16:07 skuam

Hi @skuam, sorry for taking so long to get back. I just saw your PR and it looks amazing! I am not sure if I will have time to test it. However, if you can fix the conflict, I am more than happy to merge it!

titipata avatar Dec 17 '23 12:12 titipata