scipdf_parser icon indicating copy to clipboard operation
scipdf_parser copied to clipboard

SyntaxWarning: is not with a literal

Open raffaelemancuso opened this issue 3 years ago • 1 comments

mypy throws these warnings.

Are you interested in a PR that fixes this?

[...]/.local/lib/python3.10/site-packages/scipdf/pdf/parse_pdf.py:114: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if middlename is not "":

raffaelemancuso avatar Sep 30 '22 15:09 raffaelemancuso

Issue Resolved

Hi @raffaem ,

Thank you for bringing this! I'm happy to inform you that your concern has been addressed with the recent pull request #21. The syntax warnings you reported have been fixed in the parse_pdf.py file.

Specifically, the pull request addressed the following warnings: parse_pdf.py:126: "is not" with a literal. parse_pdf.py:213: "is not" with a literal. parse_pdf.py:241: "is" with a literal. parse_pdf.py:254: "is not" with a literal. parse_pdf.py:303: "is not" with a literal.

mohibullah70 avatar Mar 08 '24 12:03 mohibullah70