tinymce-docs icon indicating copy to clipboard operation
tinymce-docs copied to clipboard

Tinymce 5 docs update pt. 2

Open noxuhax opened this issue 3 years ago • 4 comments

Related Ticket:

Description of Changes:

  • Integration options
  • User interface options
  • Content appearance options
  • Content filtering options

Pre-checks:

  • [x] Branch prefixed with feature/ or hotfix/
  • [x] ~_data/nav.yml has been updated (if applicable)~
  • [x] ~Files has been included where required (if applicable)~
  • [x] ~Files removed have been deleted, not just excluded from the build (if applicable)~
  • [x] ~(New product features only) Release Note added~

Review:

  • [x] Documentation Team Lead has reviewed
  • [ ] Product Manager has reviewed

noxuhax avatar Mar 31 '22 09:03 noxuhax

@noxuhax this has merge conflicts and LGTM is failing checks, can you please fix those before we review this?

lnewson avatar Apr 06 '22 23:04 lnewson

@lnewson done. Sorry, forgot to mark it as a draft initially.

noxuhax avatar Apr 11 '22 15:04 noxuhax

@lorenzo-pomili you are absolutely right, I somehow missed that links syntax I used is a legacy one. Went thru all configuration partials and updated it to xrefs.

some of those links have changed from absolute URL to in-page references, is that correct?

Yeah, since those partials are only used on one page and those links are all referencing elements on the same page, it does not make much sense to keep those links absolute IMO.

noxuhax avatar Jun 16 '22 18:06 noxuhax

Yeah, since those partials are only used on one page and those links are all referencing elements on the same page, it does not make much sense to keep those links absolute IMO.

Regarding this, they are partials pages and can be used anywhere so the general rule is that they should be absolute xrefs otherwise they'll break when used in a page that doesn't include the needed partial. That said, given this is the TinyMCE 5 docs and aren't likely to change this might be fine 🤷

lnewson avatar Jun 16 '22 22:06 lnewson