tinymce-angular icon indicating copy to clipboard operation
tinymce-angular copied to clipboard

INT-3299: Fixed id prop logging a warning when it shouldn't

Open danoaky-tiny opened this issue 1 year ago • 0 comments

Ticket: INT-3299

Changes:

  • Added an extra check for duplicate editor IDs. As well as checking if a current element exists with that ID, it checks that this element is not equal to the elementRef in the EditorComponent. If it is, it logs a warning as before.
  • Added PropTest.ts to test: that one editor instance with an ID does not log a warning, multiple editors with the same ID does log a warning and multiple editors with different IDs does not log a warning.
  • Added a captureLogs function.
  • Added chai and edited the eslint config to support it.

Relevant Github Issue: #374

danoaky-tiny avatar Jun 17 '24 00:06 danoaky-tiny