tinygrad icon indicating copy to clipboard operation
tinygrad copied to clipboard

Uop symbolics rewrite rules

Open DKormann opened this issue 1 year ago • 5 comments

  • [x] test_lt
  • [x] test_ge
  • [x] test_lt_remove
  • [x] test_ge_remove
  • [x] test_ge_divides

DKormann avatar Jul 02 '24 20:07 DKormann

would like to get this mergeable and meanwhile continue in new draft

DKormann avatar Jul 04 '24 21:07 DKormann

See chenyu's comment above, you can't put NumNode into UOp

geohot avatar Jul 09 '24 04:07 geohot

Changes

Name                        Lines    Diff    Tokens/Line    Diff
------------------------  -------  ------  -------------  ------
tinygrad/codegen/uops.py      420     +37           20.7    +0.2


total lines changes: +37

github-actions[bot] avatar Jul 09 '24 04:07 github-actions[bot]

See chenyu's comment above, you can't put NumNode into UOp

so I just remove NumNode completely how's that

DKormann avatar Jul 09 '24 04:07 DKormann

could remove Node and Variable too only TempVar would be annoying to remove until refactor of how we use Variable Uops more generally

DKormann avatar Jul 09 '24 04:07 DKormann

done in master

chenyuxyz avatar Aug 06 '24 02:08 chenyuxyz