onnx if op

Open rouseabout opened this issue 2 years ago • 2 comments

use diff -w to see run_onnx changes

test/external/external_test_onnx_backend.py:

before: 167 failed, 645 passed, 1822 skipped, 1 warning in 28.40s

after: 167 failed, 646 passed, 1821 skipped, 1 warning in 28.58s

Jun 21 '23 08:06 rouseabout

Tests failing. Don't mix large whitespace changes and functional changes.

Jun 21 '23 17:06 geohot

Still a massive change (+132 -124)...why?

Jun 26 '23 05:06 geohot

Indentation. Alternative approach, say moving the op eval loop out of run_onnx scope, will incur more changes.

Jun 27 '23 11:06 rouseabout

Like I said, don't mix large whitespace changes and functional changes.

Jun 27 '23 15:06 geohot