tensorflow2-generative-models icon indicating copy to clipboard operation
tensorflow2-generative-models copied to clipboard

incorrect discriminator loss in GAIA notebook

Open hanshengchiu opened this issue 6 years ago • 4 comments

The following is discriminator's loss in the GAIA notebook. Shouldn't the d_xg_loss be negative? disc_loss = d_xg_loss + d_x_loss - tf.clip_by_value(d_xi_loss, 0, d_x_loss)

hanshengchiu avatar Mar 04 '20 18:03 hanshengchiu

I encountered the same problem when I reproduced the code.

Abel1802 avatar Nov 17 '20 04:11 Abel1802

I should have mentioned that the notebook there was me experimenting with a variation of GAIA that I was trying out. I just added a line in the readme saying as much. But you're right. If someone wants to make a PR with the original algorithm for GAIA it would be much appreciated.

timsainb avatar Nov 17 '20 04:11 timsainb

I should have mentioned that the notebook there was me experimenting with a variation of GAIA that I was trying out. I just added a line in the readme saying as much. But you're right. If someone wants to make a PR with the original algorithm for GAIA it would be much appreciated.

Thank you!

Abel1802 avatar Nov 17 '20 04:11 Abel1802

I've got a cleaner tensorflow 1 implementation of GAIA in a private repo that I used for the 2D meshplot examples figure from the paper BTW. If anyone wants that code / access to that repo just ask. The repo is private just because its full of _Copy3.ipynb files with additional experiments that I never got around to making presentable.

timsainb avatar Nov 17 '20 04:11 timsainb