shellfuncs icon indicating copy to clipboard operation
shellfuncs copied to clipboard

Allows bash modules to live anywhere

Open jack-sanchez opened this issue 6 years ago • 3 comments

I really liked the approach here, but I wanted to be able to import a shell script from a remote directory by including that location in PYTHONPATH or with sys.path.append.

I ran the tests on my machine and they appear to be good to go. I did not add any tests for remote bash execution because it would require a bit more setup.

Also note that the implementation isn't perfect and there are likely some edge cases that I haven't handled, but as it is, it fulfills my needs and if you'd like to take the functionality then feel free :)

jack-sanchez avatar Jul 25 '19 21:07 jack-sanchez

The builds are currently failing - reason for that is the mixture of pathlib.Path and os.path-functions. I assume if you accept the suggestions those tests will pass again.

In any case: thanks for the contribution. I really appreciate it! :tada:

timofurrer avatar Jul 26 '19 06:07 timofurrer

@timofurrer thanks for the feedback and pointing me to the test failures, my environment is in the >3.6 category which explains why I hadn't noticed :)

I need to focus on getting some things worked out today so I likely won't get around to updating this until sometime in the next week or two when I have time again, but I do want to resolve the comments / suggestions!

Thanks for building this in the first place, it is an elegant solution to the problem I've been wanting to solve for some time now - but I'm not a native pythoner so solutions like this didn't occur to me!

jack-sanchez avatar Jul 26 '19 17:07 jack-sanchez

No worries, keep me posted about the updates. If you need any help, don't hesitate to just ping me :tada:

timofurrer avatar Jul 27 '19 12:07 timofurrer