swirly icon indicating copy to clipboard operation
swirly copied to clipboard

feat(swirly-renderer-next): next gen renderer

Open demensky opened this issue 3 years ago • 6 comments

  • [x] Drawing text with <path />. No need to worry about the presence of the font.
  • [x] Dynamic calculation of stream title width.
  • [x] Dynamic calculation of operator width. <foreignObject /> is not used.
  • [x] Lack of sub pixel coordinates. Clearer display.
  • [x] Rendering without browser APIs. Can be easily run in Node.js.
  • [x] complete & error now have the same radius as next. But complete & error become larger if next overlaps them. Just like here.
  • [x] Built-in dark theme!

The parser is not yet able to handle such a case (or I did not understand how):

  • [x] Has no restriction on nesting of streams.
  • [x] Nested streams in the operator.

Closes: timdp/swirly#39 Closes: timdp/swirly#40

demensky avatar Jul 13 '22 17:07 demensky

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
swirly ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 10:40AM (UTC)

vercel[bot] avatar Jul 13 '22 17:07 vercel[bot]

I was gonna suggest creating a PR so thanks! I'll do an in-depth review asap.

timdp avatar Jul 13 '22 18:07 timdp

This is not the final revision yet. I wanted to discuss with you the reorganization of styles. My suggestion is to reduce the ability to change styles from within the diagram itself, leaving only the required styles (such as observableDistanceX). Styling will be done when rendering, similar to markdown. This will avoid unnecessary customization.

demensky avatar Jul 13 '22 18:07 demensky

What are your suggestions for improving this implementation?

demensky avatar Aug 14 '22 20:08 demensky

Sorry for not being able to interest you.

demensky avatar Nov 15 '22 10:11 demensky

No, I'm the one who should be sorry.

You've raised a legitimate concern and proposed a solution. More people in OSS should do that.

However, reviewing this is quite a daunting task to me. I was going to start with a few high-level considerations, but while I genuinely do appreciate your input, I can't say I'm looking forward to putting in the raw effort.

Combined with my tendency to drift in and out of specific projects, I'm unable to give you a timeline. But rest assured, this is sitting in my inbox and I'm very much aware of it. That's the best I can do right now.

timdp avatar Nov 15 '22 10:11 timdp