Tim Diggins

Results 94 comments of Tim Diggins

@hakeem0114 Ah - ok, if it's a feature request, what benefit does it bring? (the problem statement still implies to me that it's a security issue) FYI After more looking,...

There's a problem which is I believe introduced by https://github.com/rails/rails/commit/e696534a68df8aa8f56e22df7956dcd3886f21f5 I have created a minimum repro spec for this with some ideas of how to fix (for later)

Thanks @rickychilcott for this - great work!

A couple of data points: ### 1) (Background info) basic usage running `rubocop`: using 1.5 release and adding `- test-prof` to `plugins:` in `.rubocop.yml` I'm getting a similar error (ie...

I think it seems reasonable that we no longer need to support Turbolinks 5 as per #1017 however I have a webapp and mobile app that uses thredded and is...

I agree with @nvasilevski - here's a specific argument against complexity requirements from the UK's National Cyber Security Centre: https://www.ncsc.gov.uk/collection/passwords/updating-your-approach#PasswordGuidance:UpdatingYourApproach-Donotusecomplexityrequirements Recommend closure of the issue for Devise

@fthobe Im not a maintainer/committee here so my 10c isn't worth so much 😀 A pragmatic response: My sense is that there isn't much maintainer involvement and devise is going...

One alternative that is less powerful, but maybe easier to understand is to keep the declarative disable / enable at the beginning and then a "reset" to global level at...

> oh, right, it cannot build because of node-sass... feel free to rebase this one on your other PR #1017 (which should get it green) -- I will review this...

@romanbsd Great work. Haven't reviewed in depth, but this is looking good. It breaks the tests, because the package.json and the js config in dummy / github is wildly out...