FalloutVM.cpp compiles on every build now

[rfortier]

UPDATE

Blame commit: fad3eca68d16cb013c215e823ab0edf0d488f827

Version of Skyrim Together

/dev branch, v1.6.x preview, as of commit bfdf26f9abb7bfff8ce12d7e55197e10de81fdd4 on 2024.05.05

Description

As stated in title. FalloutVM.cpp and several other files compile on every build now. FalloutVM.cpp compiles even if doing a Skyrim Client build, for example. And that doesn't make it "up to date" for xmake, build the Skyrim client again and FalloutVM.cpp will compile again.

I haven't done a git bisect to isolate a commit to blame, but v1.6.3 didn't do this. The Branchinfo commits on and just before fad3eca68d16cb013c215e823ab0edf0d488f827 seem a good place to start.

I'll see if I can get a bisect to narrow, but wanted to post what I had so far; it might be an obvious bug to someone.

Here's a typical log:

Build started at 8:50 PM...
------ Build started: Project: SkyrimImmersiveLauncher, Configuration: releasedbg x64 ------
$xmake config -y  -P . -p windows -m releasedbg -a x64 -o "build"
$xmake build -y  -P . -w "SkyrimImmersiveLauncher"
[ 51%]: compiling.releasedbg Code\client\FalloutVM.cpp
[ 57%]: compiling.releasedbg Code\client\main.cpp
[ 57%]: compiling.releasedbg Code\client\Services\Debug\DebugService.cpp
[ 67%]: compiling.releasedbg Code\client\SkyrimVM64.cpp
[ 69%]: compiling.releasedbg Code\client\TiltedOnlineApp.cpp
[ 87%]: compiling.releasedbg Code\immersive_launcher\Launcher.cpp
[ 98%]: archiving.releasedbg SkyrimTogetherClient.lib
[ 99%]: linking.releasedbg SkyrimTogether.exe
[100%]: build ok, spent 10.469s
EXEC : warning : add_cxflags("-fPIC") is ignored, please pass {force = true} or call set_policy("check.auto_ignore_flags", false) if you want to set it.
Done building project "SkyrimImmersiveLauncher.vcxproj".
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 8:50 PM and took 13.346 seconds ==========

Steps to reproduce

As stated in Description.

A simple reproducer: build Skyrim Immersive Launcher twice; second build should do nothing.

Reproduction rate

100%

• [x] Consistent: I can reproduce this bug by following the steps to reproduce 100% of the time (every time)
• [ ] Occasional: I can reproduce this bug by following the steps to reproduce around 50% of the time
• [ ] Rare: I can reproduce this bug by following the steps to reproduce around 10% or less of the time

Expected result

Fallout components do not compile when compiling Skyrim components alone. Performing a build brings components up-to-date. That is, doing two builds back-to-back, the second build does nothing.

Evidence (optional)

See log in Description