WeConnect-python Add Send Destination function

Add support for sending a route or destination to the vehicle (Fixes #8)

Sep 13 '24 15:09 DarkFox

This is great, the problem I see is, how does that behave when used downstream. So far the controls don't use complex objects as an input. When I merge this, in weconnect-mqtt there will ne a new topic, but it will not be usable. I need to think of a solution for that.

Sep 14 '24 06:09 tillsteinbach

That's a good point.

Perhaps if we allow the value to be a dict or a list of dicts, and then have a class method in Route that creates the objects?

Something like:

...
if isinstance(value, list):
    Route.create_from_list(value)
...

That way the validation logic can stay in there and not gunk up controls.py

Edit: or allow a JSON string, which is then converted?

Sep 14 '24 08:09 DarkFox

I like the json idea. This needs good testing but should be a nice solution.

Sep 14 '24 15:09 tillsteinbach

Would you prefer that I squash the commits before merging, or will you just do a squash and merge?

Sep 18 '24 09:09 DarkFox

@tillsteinbach I was wondering if there is anything I can do to help move this forward? Are there any further code changes or testing that needs to be done?

I've been running this on my own Home Assistant instance for a few weeks now, and it's working great.

Oct 06 '24 08:10 DarkFox

Sorry, it's just that I'm very busy. If you have a chance testing it with Weconnect-cli and Weconnect-mqtt, this is what is left for me to merge it.

Oct 06 '24 08:10 tillsteinbach

I understand, it's no problem at all. I'll take a look at that ASAP. 👍

Oct 06 '24 13:10 DarkFox

Apologies for the delay in finishing this PR. I've been dealing with some health issues that have impacted my ability to work on it.

I was in the process of trying to figure out the correct MQTT topic to use for sending the data, but I ran into some uncertainty there. Additionally, I'm not sure I had the CLI fully operational, which further complicated things.

Unfortunately, I don't currently have the bandwidth to finish this. If anyone else is interested in picking it up, I'd be happy to provide context on what I've done so far.

Thanks for understanding!

Dec 18 '24 18:12 DarkFox

Unfortunately I don't have access to a Volkswagen anymore. If someone would be willing to test I would be happy.

Dec 19 '24 17:12 tillsteinbach

Since this project is abandoned, I'll close this PR. I'll look into the possibility of porting it to CarConnectivity.

Jul 10 '25 10:07 DarkFox