vector-datasource icon indicating copy to clipboard operation
vector-datasource copied to clipboard

this lake loses `kind: lake` tag > z9

Open meetar opened this issue 9 years ago • 4 comments

  • What did you see?

Past zoom 9, this feature of kind: lake loses that tag.

  • What did you expect to see?

Tag would remain.

  • What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.

http://tangrams.github.io/explorer/#9.0/35.2348/136.0881/kind/lake

  • Screenshot? Props for animated gifs.

biwako

meetar avatar Aug 23 '16 14:08 meetar

Looks like we're not picking up this lake from OSM, so it drops out when we transition from NE. The relation multi-polygon looks like it should come through as a lake (it's tagged natural=water), so further investigation is required.

zerebubuth avatar Aug 23 '16 14:08 zerebubuth

Oh, wait... I see what's happening here. The lake is tagged natural=water, water=lake, and we don't have a special case for that, we're just assigning kind: water. There are probably many features out there which NE considers lakes but which are only tagged as more general "water" in OSM.

@nvkelso given that there's a water=lake additional tag on this particular natural=water, should we use that to "upgrade" it to a kind: lake?

zerebubuth avatar Aug 23 '16 15:08 zerebubuth

Yeah, I think so. Tagging for v1.1.

nvkelso avatar Aug 25 '16 17:08 nvkelso

Another example: https://www.openstreetmap.org/relation/62210#map=17/48.83096/2.41355

image

Over 500k features are tagged water: lake!

  • https://wiki.openstreetmap.org/wiki/Tag:water=lake?uselang=en-US
  • https://taginfo.openstreetmap.org/keys/water#values

Because this might be a breaking change, let's debate if kind or kind_detail assignment.

Other common values:

value count % desc
pond 918 359 42.88% An pond
lake 560 017 26.15% A body of relatively still fresh or salt water of considerable size, localized in a basin that is surrounded by land
reservoir 239 912 11.20% An artificial lake which may be used to store water.
intermittent 223 875 10.45%  
river 72 422 3.38% The water covered area of a river
wastewater 21 335 1.00% A clarifier/settling basin of a wastewater treatment plant.
basin 18 118 0.85% -  
canal 16 286 0.76% A body of canal
oxbow 13 751 0.64% An oxbow lake
lagoon 6 774 0.32% A lagoon
salt 6 535 0.31% -  
ditch 5 835 0.27% -  
stream 4 834 0.23% -  

nvkelso avatar Oct 30 '19 17:10 nvkelso