vector-datasource icon indicating copy to clipboard operation
vector-datasource copied to clipboard

include `taqueria=yes` in tiles for burrito POI icon

Open burritojustice opened this issue 9 years ago • 10 comments

test case: http://www.openstreetmap.org/node/1974596596

burritojustice avatar Jun 09 '16 22:06 burritojustice

We could do this by setting a new kind of taqueria when:

  • amenity=restaurant
  • cuisine=mexican
  • taqueria=yes

There's already an icon in the spritesheet for taquerias (it's a burrito).

nvkelso avatar Jun 09 '16 23:06 nvkelso

There's 7 instances of taqueria=yes in the database, and 7 instances of cuisine=taqueria as well. In addition, there's 32 instances of cuisine=burrito. Would it be better to use the existing and (slightly) more popular tags rather than inventing new ones?

cuisine=taqueria: node 4117252907, node 2138638734 cuisine=burrito: node 1106966270, way 390965167

Also, we should support both amenity=restaurant and amenity=fast_food.

zerebubuth avatar Jun 10 '16 09:06 zerebubuth

@burritojustice does the cuisine tag work for you? I agree with @zerebubuth that's the more consistent / flexible thing to do here.

nvkelso avatar Jun 10 '16 16:06 nvkelso

Matt's 1st example is already coming thru tiles, so this is probably a no-op.

screen shot 2016-06-10 at 09 48 45

nvkelso avatar Jun 10 '16 16:06 nvkelso

The intent was to mark taquerias and food trucks that serve burritos, more so than just "burritos" themselves (say in a Mexican restaurant, or in a Chili's), so I think cuisine=taqueria is a reasonable approach.

@nvkelso, were you thinking of more than one tag triggering the icon? I am not so sure that cuisine=burrito is the best thing to include. In all honesty, I could make a whole burrito= taxonomy but that's a different discussion. burrito=yes, burrito=mission, burrito=california, burrito=sad, burrito=corporate

burritojustice avatar Jun 12 '16 18:06 burritojustice

@burritojustice it seems like the data is already configured correctly for this, it's now a question of updating the stylesheet:

  • when either (amenity=restaurant or amenity=fast_food) && (cuisine=taqueria &/or cuisine=burrito)
  • then we'd assign the burrito icon

A generic Mexican restaurant I think would be getting cuisine=mexican by default, and Chili would be getting something else entirely. But Chipotle would I think get cuisine=burrito so would get the icon unless we took some other action.

nvkelso avatar Jun 12 '16 20:06 nvkelso

I think having a secondary tag for burrito=corporate on Chipotle, Qdoba, etc... would be great. We can certainly bring that in for extra detail. Perhaps the icon could be a limp-looking burrito wearing a necktie? :wink:

To be clear: I'm totally in favour of extra detail to differentiate between mexican restaurants, places that just happen to have a (probably sad) burrito on the menu, and proper taquerias. It's just nice to re-use and promote existing tags, where appropriate, rather than invent duplicates or near-duplicates.

zerebubuth avatar Jun 14 '16 10:06 zerebubuth

Thanks Matt -- with you on promoting existing tags and avoiding tagflation.

I'm good with cuisine=taqueria && along with (amenity=restaurant or amenity=fast_food) -- the question is could/should we add a burrito=mission to be the final thing that makes the burrito appear?

Also, are food trucks a category? Would they fall under amenity=restaurant?

burritojustice avatar Jul 01 '16 20:07 burritojustice

Having an additional tag for the burrito type sounds great to me. I can't find any other attempts to describe that in the data, so it seems worthwhile documenting the suggested usage (e.g: burrito=corporate/mission/wet etc...) somewhere.

Food trucks don't seem to be well-mapped as a separate category, at least that I could find. There's a very small number of instances of them tagged with a note saying they're food trucks, but otherwise as amenity=fast_food and takeaway=only (overpass). I suppose it's difficult to map as a "permanent" feature unless you know that the truck is always at a certain spot at a certain time. Definitely worth adding opening hours! Feel free to add food_truck=yes or similar - perhaps it will catch on :wink:

zerebubuth avatar Jul 06 '16 11:07 zerebubuth

To clarify for Olga:

We're only adding 'burrito' tag to tiles. We should whitelist values, but I'm not sure what values to add. The list seems small from John.

nvkelso avatar Jul 15 '16 21:07 nvkelso