mapbox-vector-tile icon indicating copy to clipboard operation
mapbox-vector-tile copied to clipboard
verified publisher icon tilezen

On invalid geometry make valid and clean

Open engobi opened this issue 9 years ago • 5 comments

Adding new geometry validity function on_invalid_geometry_make_valid_and_clean, that applies the validity function clean_multi in case of invalids multipolygons have been returned by make_it_valid function.

engobi avatar Nov 10 '16 15:11 engobi

Coverage Status

Coverage decreased (-0.7%) to 94.803% when pulling 4222d97964f151354fb35adf5c8f7a7861d46b97 on Mappy:on_invalid_geometry_make_valid_and_clean into a1c9916fdcf055d40a4322ca5f356c539b6dcd5c on tilezen:master.

coveralls avatar Nov 14 '16 12:11 coveralls

Is there a reason why we always don't want to perform this operation? ie, right before returning a multipolygon in the other make valid path, always ensure it's "cleaned" first?

rmarianski avatar Nov 15 '16 15:11 rmarianski

@engobi Can you bring this PR up to date, please?

nvkelso avatar Mar 15 '17 17:03 nvkelso

Coverage Status

Coverage decreased (-0.4%) to 91.236% when pulling 68772f3d337c098351b21aaa4ba30650892f0a40 on Mappy:on_invalid_geometry_make_valid_and_clean into 5f54ef205fc715efae0695ddd21afce8aeface14 on tilezen:master.

coveralls avatar May 11 '17 10:05 coveralls