pd icon indicating copy to clipboard operation
pd copied to clipboard

pd-server deploy failed when change source code

Open x-lambda opened this issue 1 year ago • 3 comments

Feature Request

Describe your feature request related problem

Describe the feature you'd like

I clone and change pd source code, and make build successed. but it can't run with bin when I deploy with tiup. I found out that it was because the dirty version was used during compilation. -X "http://github.com/tikv/pd/server/versioninfo.PDReleaseVersion=fd2094e-dirty"

Describe alternatives you've considered

Is there any documentation on how to compile and deploy after modifying the source code?

Teachability, Documentation, Adoption, Migration Strategy

x-lambda avatar May 18 '24 08:05 x-lambda

Did you check your git tag?

HuSharp avatar May 20 '24 02:05 HuSharp

Did you check your git tag?

I handled it as follows:

  1. git checkout origin/release-5.3
  2. change source code
  3. make build

and the version of bin is xxxx-dirty

x-lambda avatar May 20 '24 02:05 x-lambda

Is it convenient to run git tag under your pd repository? The purpose is to check if a tag is related to fd2094e.

HuSharp avatar May 20 '24 03:05 HuSharp