pd icon indicating copy to clipboard operation
pd copied to clipboard

ctl: replace config with HTTP SDK

Open HuSharp opened this issue 2 years ago • 6 comments

What problem does this PR solve?

Issue Number: Ref #7300

What is changed and how does it work?

ctl: replace config with HTTP SDK

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

HuSharp avatar Feb 21 '24 03:02 HuSharp

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Feb 21 '24 03:02 ti-chi-bot[bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Feb 21 '24 03:02 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 75.42088% with 73 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (6998fb5) to head (f15bd60). Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7834      +/-   ##
==========================================
+ Coverage   77.59%   77.66%   +0.07%     
==========================================
  Files         474      474              
  Lines       61883    62008     +125     
==========================================
+ Hits        48019    48160     +141     
+ Misses      10334    10308      -26     
- Partials     3530     3540      +10     
Flag Coverage Δ
unittests 77.66% <75.42%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 21 '24 07:02 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 29 '24 18:03 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from husharp, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 28 '24 08:08 ti-chi-bot[bot]

@HuSharp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test f15bd6037ef9b3cfc1119df4ed824d90ba20e846 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Aug 28 '24 08:08 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Sep 27 '24 09:09 ti-chi-bot[bot]