pd icon indicating copy to clipboard operation
pd copied to clipboard

ratelimit: support modify BBR config by API

Open CabinfeverB opened this issue 2 years ago • 5 comments

What problem does this PR solve?

Issue Number: ref #7167

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

CabinfeverB avatar Oct 31 '23 11:10 CabinfeverB

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Oct 31 '23 11:10 ti-chi-bot[bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Oct 31 '23 11:10 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jan 05 '24 08:01 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 96.31148% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.53%. Comparing base (1772ad0) to head (34b6821). Report is 314 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7291      +/-   ##
==========================================
+ Coverage   73.45%   73.53%   +0.07%     
==========================================
  Files         432      433       +1     
  Lines       47886    48123     +237     
==========================================
+ Hits        35175    35387     +212     
- Misses       9667     9683      +16     
- Partials     3044     3053       +9     
Flag Coverage Δ
unittests 73.53% <96.31%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 21 '24 10:02 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 09 '24 10:04 ti-chi-bot[bot]