change method name StoreVersion.minTiKVVersion to StoreVersion.isTi…
What problem does this PR solve?
Problem Description:
The name of the current minTiKVVersion method is confusing, TiSpark changed the method name to isTiKVVersionGreatEqualThanVersion in #2481. Currently, tiSpark is trying to refactor the client using client-java, hopefully, client-java can modify this error-prone method name.
/run-all-tests
/run-all-tests
This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity.
Codecov Report
Base: 34.81% // Head: 34.90% // Increases project coverage by +0.08% :tada:
Coverage data is based on head (
41844ea) compared to base (1b5edcd). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #647 +/- ##
============================================
+ Coverage 34.81% 34.90% +0.08%
- Complexity 1433 1441 +8
============================================
Files 278 278
Lines 17377 17381 +4
Branches 1974 1976 +2
============================================
+ Hits 6049 6066 +17
+ Misses 10715 10703 -12
+ Partials 613 612 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/main/java/org/tikv/common/StoreVersion.java | 69.76% <ø> (ø) |
|
| src/main/java/org/tikv/common/TiSession.java | 70.43% <100.00%> (+0.06%) |
:arrow_up: |
| ...java/org/tikv/common/region/RegionStoreClient.java | 52.49% <100.00%> (ø) |
|
| ...rc/main/java/io/grpc/netty/NettyClientHandler.java | 56.03% <0.00%> (-0.87%) |
:arrow_down: |
| ...ty/handler/codec/http2/Http2ConnectionHandler.java | 48.65% <0.00%> (+0.48%) |
:arrow_up: |
| src/main/java/org/tikv/common/region/TiRegion.java | 73.50% <0.00%> (+4.27%) |
:arrow_up: |
| ...ain/java/org/tikv/common/region/RegionManager.java | 79.73% <0.00%> (+5.73%) |
:arrow_up: |
| .../main/java/org/tikv/common/region/TiStoreType.java | 83.33% <0.00%> (+16.66%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.