client-java icon indicating copy to clipboard operation
client-java copied to clipboard

[to #734] add time unit for ttl param

Open razertory opened this issue 3 years ago • 3 comments

What problem does this PR solve?

add methods with time unit param for RawKVClientBase for easier use

What is changed and how does it work?

add default method in interface RawKVClientBaseinclude

  • void put(ByteString key, ByteString value, long ttl)
  • Optional<ByteString> putIfAbsent(ByteString key, ByteString value, long ttl)
  • void compareAndSet(ByteString key, Optional<ByteString> prevValue, ByteString value, long ttl)
  • void batchPut(Map<ByteString, ByteString> kvPairs, long ttl);

Code changes

  • Has methods of interface change YES

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

  • No side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

razertory avatar Aug 11 '22 16:08 razertory

This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.

github-actions[bot] avatar Sep 11 '22 00:09 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Sep 18 '22 00:09 github-actions[bot]

Codecov Report

Patch coverage: 45.45% and project coverage change: -3.08 :warning:

Comparison is base (a523312) 38.11% compared to head (adf7060) 35.04%.

:exclamation: Current head adf7060 differs from pull request most recent head 4f0b3ba. Consider uploading reports for the commit 4f0b3ba to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #646      +/-   ##
============================================
- Coverage     38.11%   35.04%   -3.08%     
+ Complexity     1613     1448     -165     
============================================
  Files           278      279       +1     
  Lines         17482    17391      -91     
  Branches       1986     1975      -11     
============================================
- Hits           6663     6094     -569     
- Misses        10154    10681     +527     
+ Partials        665      616      -49     
Impacted Files Coverage Δ
src/main/java/org/tikv/raw/RawKVClientBase.java 45.45% <45.45%> (ø)

... and 43 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 16 '22 03:12 codecov[bot]