devmail icon indicating copy to clipboard operation
devmail copied to clipboard

Move classes to `Devmail` "namespace"?

Open oneiros opened this issue 5 years ago • 1 comments

First of all thanks for devmail. It has been immensely helpful in getting specs up and running for https://github.com/oneiros/carbon_smtp_adapter/

Since I use it in a way it might not have been intended for (as a library rather than a stand-alone tool), I am a bit concerned about how devmail "pollutes" the global namespace.

Best practice in crystal (quite similar to ruby) is to wrap all classes in src/devmail in a Devmail module/namespace.

Would you accept a PR moving all classes into such a namespace?

oneiros avatar May 19 '20 14:05 oneiros

Hi @oneiros ,

Yes, absolutely! I clearly made the wrong decision back when I wrote this. 😄

tijn avatar May 19 '20 15:05 tijn