spatialsample icon indicating copy to clipboard operation
spatialsample copied to clipboard

GIFs in the Buffering article have not updated to the new autoplot

Open mikemahoney218 opened this issue 3 years ago • 4 comments

Both the main and dev site still use the old (fully opaque) autoplot method for buffering GIFs: https://spatialsample.tidymodels.org/dev/articles/buffering.html

I'm not entirely sure why that's happening; I guess we need to do something to force a re-render.

mikemahoney218 avatar Jun 21 '22 16:06 mikemahoney218

I have heard people say that this lets us trigger a render: https://github.com/tidymodels/spatialsample/blob/77ef63b704c6d6d572100e6ac44d3a838adbc66b/.github/workflows/pkgdown.yaml#L10 But honestly I have never gotten it to work and I'm not sure what to do.

juliasilge avatar Jun 21 '22 18:06 juliasilge

Ooh! I didn't realize this had that under on.

That gives you this drop-down on the Actions page when you click into a given workflow: Screenshot from 2022-06-21 14-35-46

I used it to kick a job over at https://github.com/tidymodels/spatialsample/actions/runs/2537504246 :crossed_fingers:

mikemahoney218 avatar Jun 21 '22 18:06 mikemahoney218

Didn't seem to help, unfortunately -- both the dev and main sites are still fully opaque. Will investigate further.

mikemahoney218 avatar Jun 21 '22 19:06 mikemahoney218

Alright, after poking around I can confirm it's not the following things:

  1. Locally, the PNGs are transparent but the pkgdown vignette GIFs are not. So it's not the autoplot method.
  2. GHA has Cairo, so it's not that https://github.com/tidymodels/spatialsample/runs/7030251017?check_suite_focus=true#step:6:13
  3. ggsave on GHA preserves transparency, so it's not that https://github.com/tidymodels/spatialsample/actions/runs/2551516725
  4. Using a different device (namely ragg::agg_png) doesn't change things, so it's not that

The speculation (from Hadley and Christophe) is that it may be due to looping through the plots via walk, but we haven't found any concrete problems.

mikemahoney218 avatar Jul 12 '22 17:07 mikemahoney218