dials icon indicating copy to clipboard operation
dials copied to clipboard

add freq_itemsets tunable param

Open Wander03 opened this issue 8 months ago • 3 comments

@kbodwin

Adds new function for min_support to dials to support adding freq_itemsets to tidyclust, see https://github.com/tidymodels/tidyclust/pull/210

Wander03 avatar Jun 19 '25 23:06 Wander03

Thank you for the PR! Similarly to #389, I've kicked off the actions on it but I'll hold of reviewing until Emil has had a chance to look at the corresponding tidyclust PR.

hfrick avatar Jun 24 '25 16:06 hfrick

Quick note on the comment on line 16 of param_min_support - we believe this param would be better using finalize, but it was out-of-scope for the project this year. It works fine now and defaults to reasonable values; just noting for a future upgrade.

kbodwin avatar Jun 29 '25 23:06 kbodwin

@kbodwin Could you turn that into an issue instead of the code comment? That makes it much easier to keep track of in the longer term.

hfrick avatar Jul 03 '25 13:07 hfrick