titanium-sdk icon indicating copy to clipboard operation
titanium-sdk copied to clipboard

fix: animation default values

Open janvennemann opened this issue 5 years ago • 1 comments

This adds a basic test suite for Ti.UI.Animation based on the generate-test command.

The tests uncovered two issues which i've fixed in this PR as well:

  • Fixes the default values of repeat and autoreverse to return the correct values instead of undefined.
  • iOS: Store the current animation complete callback from view.animate(animation, callback) before firing the complete event. This could cause a race condition in certain scenarios when running multiple animation after each other causing the callback from the last animation to be called multiple times.

Also updates the examples in the docs to use up-to-date coding styles and consistent formatting.

janvennemann avatar Nov 12 '20 15:11 janvennemann

Warnings
:warning: There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
:warning: This PR has milestone set to 10.0.0, but the version defined in package.json is 9.3.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
:warning:

:mag: Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

Messages
:book: :fist: The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by :no_entry_sign: dangerJS against c72efe74c551e62dc2f42f907630c1edcbf7143e

build avatar Nov 12 '20 15:11 build