Vinh Tran
Vinh Tran
I think I got a sense of what the full solution would look like. Here is a breakdown: * https://github.com/biomejs/biome/pull/8112 * https://github.com/tidefield/biome/pull/3 * https://github.com/tidefield/biome/pull/4 @ematipico @arendjr https://github.com/tidefield/biome/pull/4 is my "creative"...
How we decide to pull the TypeScript repo is orthogonal to how to address the global resolver integration. So it's fine to close the PR if it conflicts with our...
> I do think we need to throw out the existing IDs Yes. I forgot to mention this. > The generated type definitions should replace what we have. How do...
I can probably fix this 👀. Feel free to assign the issue to me.
I couldn't reproduce the issue. I tried removing the `await` token from https://github.com/0x80/typescript-monorepo/blob/912cb9ca735680fd45c67923c7ebd86b0412e14e/services/api/src/v1/handlers.ts#L10C9-L10C20. Biome reported ``` ✖ A "floating" Promise was found, meaning it is not properly handled and could...
The root cause is in `Readonly` type (and probably any other utility types). See [this playground](https://next.biomejs.dev/playground/?lintRules=noFloatingPromises&code=dAB5AHAAZQAgAEEAVAB5AHAAZQAgAD0AIAB7AAoAIAAgAHIAZQB0AHUAcgBuAFAAcgBvAG0AaQBzAGUAOgAgACgAKQAgAD0APgAgAFAAcgBvAG0AaQBzAGUAPAB2AG8AaQBkAD4ACgB9AAoACgB0AHkAcABlACAAQQBSAGUAYQBkAG8AbgBsAHkAVAB5AHAAZQAgAD0AIABSAGUAYQBkAG8AbgBsAHkAPAB7AAoAIAAgAHIAZQB0AHUAcgBuAFAAcgBvAG0AaQBzAGUAOgAgACgAKQAgAD0APgAgAFAAcgBvAG0AaQBzAGUAPAB2AG8AaQBkAD4ACgB9AD4ACgAKAGEAcwB5AG4AYwAgAGYAdQBuAGMAdABpAG8AbgAgAGMAYQBsAGwAZQByACgAcgBlAGEAZABvAG4AbAB5ADoAIABBAFIAZQBhAGQAbwBuAGwAeQBUAHkAcABlACwAIABvAGIAagBlAGMAdAA6ACAAQQBUAHkAcABlACkAIAB7AAoAIAAgAC8ALwAgAEwnCgAgACAAcgBlAGEAZABvAG4AbAB5AC4AcgBlAHQAdQByAG4AUAByAG8AbQBpAHMAZQAoACkAOwAKACAAIAAvAC8AIAAFJwoAIAAgAG8AYgBqAGUAYwB0AC4AcgBlAHQAdQByAG4AUAByAG8AbQBpAHMAZQAoACkAOwAKAH0ACgA%3D) for smaller reproduction. The expression that returns a promise from a Readonly type does...
FYI I'm starting to work on this soon. I'll report back when I'm done.
FWIW it was already implemented recently https://zed.dev/extensions/grit
Any update here? Happy to send an PR if no one has worked on this.
Let's see what I can do.