vortex icon indicating copy to clipboard operation
vortex copied to clipboard

Apple Silicon compatibility

Open jarmitage opened this issue 3 years ago • 8 comments

  • PyQt5 needs to be updated to PyQt6
  • QScintilla depends on PyQt5 and needs to be updated to PyQt6-QScintilla (https://pypi.org/project/PyQt6-QScintilla)
  • liblo, which underlies pyliblo, does not support Apple Silicon. Probably need to switch to python-osc or osc4py3

jarmitage avatar Dec 06 '22 16:12 jarmitage

As a workaround, is it possible to enable installing without OSC or a GUI?

This would also be useful anyway for using Vortex's Tidal parser in other Python projecs

jarmitage avatar Dec 06 '22 16:12 jarmitage

Have you got a reference for liblo not supporting apple silicon? I don't think we'd want to move to a pure python library as that likely wouldn't work as well as liblo. Happy to receive PRs for qt6 etc tho.

yaxu avatar Dec 06 '22 16:12 yaxu

Ok, might be that liblo is fine, but having issues trying to install pyliblo3 on M1: https://github.com/gesellkammer/pyliblo3/issues/2

jarmitage avatar Dec 06 '22 16:12 jarmitage

Re Qt6, I can't test if it works yet, and wouldn't be able to test on Debian etc.

"In theory" it's just modifying pyproject.toml to:

PyQt6 = "^6.4.0"
PyQt6-QScintilla = "^2.13.3"

And then in gui.py:

from PyQt6.Qsci import *
from PyQt6.QtCore import *
from PyQt6.QtGui import *
from PyQt6.QtWidgets import *

So maybe if a Linux user can check that Qt6 doesn't break anything, then a PR might be possible.

jarmitage avatar Dec 06 '22 16:12 jarmitage

I checked the update to PyQt6 on a windows machine. I had to change a couple of lines in gui.py to get it running. Some symbolic constants have changed. @jarmitage could you get it running without these changes?

gui.patch

karstenj avatar Feb 05 '23 13:02 karstenj

Ich checked the change also in the github CI and it build also on Linux. I issued a pull request #38 for the change.

karstenj avatar Feb 06 '23 18:02 karstenj

@munshkr has merged the changes for PyQt6 to the main branch. @jarmitage could you check it? Maybe also to update the readme for MacOS.

karstenj avatar Feb 08 '23 13:02 karstenj

@karstenj I still cannot get this running on macOS due to the same issue with pyliblo3 on M1

jarmitage avatar Mar 24 '23 11:03 jarmitage