qgit icon indicating copy to clipboard operation
qgit copied to clipboard

Adding in cocoainitializer class to prevent mem leaks on Cocoa-based Macs

Open NucleaPeon opened this issue 5 years ago • 3 comments

  • Ignore .DS_Store folder setting files, src/qmake when building in tree
  • added name to about contributors

NucleaPeon avatar Mar 15 '20 19:03 NucleaPeon

What is the license on the cocoainitializer.{h,mm} files? Headers indicate authors other than you.

tibirna avatar Mar 23 '20 01:03 tibirna

Sharp eye. I pulled the code from https://github.com/torrent-file-editor/torrent-file-editor. License file reports GPL 3.0 https://github.com/torrent-file-editor/torrent-file-editor/blob/master/LICENSE

Edit (clarification)

I didn't write it, I left in the previous authors. I attempted to find a fix for the same issue on a project I'm working on. In an obscure mailing list, I found a reference to CocoaInitializer. Searching for it, I found a github result that had those two files in it. I'm not sure if the repo owners wrote it themselves, but information was sparse and it fixed my issue.

The QT developers dismissed the NS pool memory autorelease issue, saying 5.3.1/2 was no longer going to be supported for snow leopard going forward and I haven't seen the issue on much later versions of OS X (10.11)

NucleaPeon avatar Mar 23 '20 05:03 NucleaPeon

I haven't seen the issue on much later versions of OS X

I suppose this PR is no longer relevant then?

filiperinaldi avatar Jan 08 '22 20:01 filiperinaldi