markdownify icon indicating copy to clipboard operation
markdownify copied to clipboard

Without jQuery?

Open tandberg opened this issue 11 years ago • 10 comments

What about a version without jQuery? I can only see jQuery being used for the selector. What about markdownify a standalone module?

tandberg avatar Apr 10 '15 19:04 tandberg

Amazing idea :) document.getElementById is great too, agreed !

tibastral avatar Apr 10 '15 19:04 tibastral

document.querySelectorAll is a good one.

tandberg avatar Apr 10 '15 19:04 tandberg

Perfect ! If you do it (and change the filename, I would be happy to merge it)

  • Thibaut Assus jobboardmaker creator parisrb organizer

On 10 Apr 2015 at 21:41:42, Øystein Tandberg ([email protected]) wrote:

document.querySelectorAll is a good one.

— Reply to this email directly or view it on GitHub.

tibastral avatar Apr 10 '15 19:04 tibastral

Hey @tandberg @tibastral . I would be glad to help along.

Should we create a new branch to work on jQuery isolation?

Here are some quick thoughts on it:

  1. Wrap the library around UMD code
  2. Replace all jQuery references with their Vanilla JS
  3. Test the whole thing

kbariotis avatar Apr 11 '15 19:04 kbariotis

Yep, it's a good idea.

tibastral avatar Apr 15 '15 07:04 tibastral

Here's a draft.

What do you think? It works but it's WIP.

kbariotis avatar Apr 18 '15 16:04 kbariotis

That’s cool, but don’t you think we could do something like another file for calling it from jquery if you want to ?

  • Thibaut

On Saturday 18 April 2015 at 18:44, Kostas Bariotis wrote:

Here's (https://github.com/kbariotis/markdownify/blob/withoutjquery/lib/jquery.markdownify.js) a draft and the PR (https://github.com/tibastral/markdownify/compare/master...kbariotis:withoutjquery). What do you think? It works but it's WIP.

— Reply to this email directly or view it on GitHub (https://github.com/tibastral/markdownify/issues/5#issuecomment-94179894).

tibastral avatar Apr 20 '15 19:04 tibastral

Hi @tibastral ,

what do you mean by calling it from jquery? You still can use it along with jQuery, you just don't depend on jQuery. Do I miss something?

Glad you liked it.

kbariotis avatar Apr 20 '15 20:04 kbariotis

That seems really cool. What do you think people ?

  • Thibaut

On Monday 20 April 2015 at 22:08, Kostas Bariotis wrote:

Hi @tibastral (https://github.com/tibastral) , what do you mean by `calling it from jquery'? You still can use it along with jQuery, you just don't depend on jQuery. Do I miss something? Glad you liked it.

— Reply to this email directly or view it on GitHub (https://github.com/tibastral/markdownify/issues/5#issuecomment-94555682).

tibastral avatar Apr 20 '15 20:04 tibastral

:+1:

mattwilsn avatar May 20 '15 14:05 mattwilsn