streamlit-javascript icon indicating copy to clipboard operation
streamlit-javascript copied to clipboard

release pipeline broken

Open thunderbug1 opened this issue 9 months ago • 2 comments

the release pipeline to deploy 1.42.0 to pypy is currently broken.

I don't have time right, now to fix it, so I leave this to not forget it.

thunderbug1 avatar Apr 04 '25 12:04 thunderbug1

I have never deployed anything yo pypy so with more information I will look at it if that helps.

Also, Thank you for you recognition. I would be interested in making this component the ultimate extension for running javascript in the browser in a streamlit application.

I should have noticed that the example.png and examples directory include using an await to start the expression you pass nto the component. From the dcumentation It can only be used inside an async function or at the top level of a module.

An eval contents is not the top level, which is why I changed the JavascriptComponent.tsx code to result = await eval(js_code). Previously the component used an inplace async function, to wrap the await which meant the component often did more work than needed.

So we should remove example.png and the examples directory, and rely on dev.py and README.md for usage.

Do you think that is sufficient documention? or should we provide more..

Strings-RH avatar Apr 07 '25 14:04 Strings-RH

I have never deployed anything yo pypy so with more information I will look at it if that helps.

Yes that would be great, I think in the pipeline the paths of the Manifest.in are wrong. The original version I deployed manually but I don't have that setup anymore and I think it is easier and probably the same amount of work to setup an automatic pipeline right away.

So far, I only setup a poetry based pipeline for another project once which works well but was also some trial and error to get right.

Also, Thank you for you recognition. I would be interested in making this component the ultimate extension for running javascript in the browser in a streamlit application.

That would be great yeah. I personally don't use this code anymore but based on the github stars it seems somewhat popular. Since I don't have a lot of time these days, are you interested to become a Co-Maintainer of the project in general? I am willing to still do work on it but that might not always be fast.

So we should remove example.png and the examples directory, and rely on dev.py and README.md for usage.

I think that should be fine, people will ask if things are unclear.

thunderbug1 avatar Apr 08 '25 17:04 thunderbug1