bayesian-optimization icon indicating copy to clipboard operation
bayesian-optimization copied to clipboard

A coding error in gp.py

Open lyq998 opened this issue 5 years ago • 1 comments

In line 48: expected_improvement[sigma == 0.0] == 0.0 It should be: expected_improvement[sigma == 0.0] = 0.0

lyq998 avatar Oct 17 '20 08:10 lyq998

I wonder what that command means. In that case, I think it might work as below..

if sigma equals zero, index 1 (sigma==0 -> True), i.e., expected_improvement[1]=0? otherwise, index 0 (sigma !=0 -> False), i.e., expected_improvement[0]=0?

If I'm wrong, please let me know. Thanks in advance

syunlee avatar Aug 10 '22 01:08 syunlee