jarchivelib icon indicating copy to clipboard operation
jarchivelib copied to clipboard

Preserve executability of files for tar archives

Open masc3d opened this issue 7 years ago • 3 comments

contributing to #23

masc3d avatar Oct 31 '18 20:10 masc3d

it seems that this PR only covers one very specific case and introduces quite a lot of changes just to make that one case work. i think it would be more useful to take a more general approach to #23 using the Java 7 features.

thrau avatar Nov 08 '18 21:11 thrau

@thrau yes, it covers "only" the most common and relevant use case, as preserving executability is a key feature of eg tar archives.

there's not really many changes here, but you probably refer to fixing the inconsistent way factory has been handling CommonsArchiver This was necessary and should be merged anyhow as it's a potential generic defect.

imho best way forward would be to merge and do minor cleanup if necessary after #23 has been implemented.

masc3d avatar Nov 10 '18 11:11 masc3d

everything to make it work is essentially in specialized TarAchiver

masc3d avatar Nov 10 '18 11:11 masc3d