thoughtworks
fix: mismatch of parameter and value
this fixes an exception which appears when a branch name is passed into the api request to the sha query parameter. Fixed to be consistent witch parameters and values to branch, usage of sha would only get a single commit.
Hi @marcohutzsch1234, we will take a look at Github's api documentation and get back to you!
Hi @marcohutzsch1234, the current implementation it is based on Github API doc where the sha parameter is described as
SHA or branch to start listing commits from. Default: the repository’s default branch (usually master).
which is accepting value as either sha or branch. Currently from our a few testing the sha is still working as expected when passing branch name as its value.
Could you please help share a bit more details about the "exception" you have met and where does the branch parameter come from? (We have tried to pass the branch name as branch parameter and indeed it looks like can perform same as sha parameter. But since we could not find Github official doc about this parameter so we are a bit concerning on it e.g. whether it is still an experimental feature and how is the performance, etc.)
