docs icon indicating copy to clipboard operation
docs copied to clipboard

Can not get fee by txHash with cosmos-sdk

Open Wangmmx opened this issue 2 years ago • 2 comments

After upgrade, the fee info is always 0 urune in txBody in this api: Is this a bug? https://thornode.ninerealms.com/cosmos/tx/v1beta1/txs/E070DD5C81CFA80A5420FD583B73706F13178CF43F8ACFD3FB598C09A82EFEC7

"fee": {
    "amount": [
        {
            "denom": "urune",
            "amount": "0"
        }
    ],
    "granter": "",
    "payer": "",
    "gas_limit": "80000000"
},

Wangmmx avatar Jul 19 '23 08:07 Wangmmx

Maybe ask in GitLab; these links (their discussion threads) are particularly relevant, I think.

https://gitlab.com/thorchain/thornode/-/issues/1582

https://gitlab.com/thorchain/thornode/-/merge_requests/2992#note_1465996803

"don't think we should compute/store it if its not going to be used"

(I will also check by asking there just in case.)

Multipartite avatar Jul 21 '23 11:07 Multipartite

Thanks to your reply

But it does not make sense, because there was fee in body before, but now it is gone. The impact of the upgrade should be notified in advance. You don’t need to store it, but the information on the chain must be accurate. There is no value in the api, but the browser shows it. This is inconsistent.

Wangmmx avatar Jul 21 '23 12:07 Wangmmx