vscode-github-theme icon indicating copy to clipboard operation
vscode-github-theme copied to clipboard
verified publisher icon thomaspink

Changes between Github and Theme for a simple JS code

Open tiago-marques opened this issue 7 years ago • 7 comments

Changes found:

  1. Consts color
  2. Params color
  3. Reserved word color (undefined, event)

Source: https://github.com/Tiago-Marques/restify-mongoose/blob/master/index.js

Preview from Github URL: realgithub

Preview from Github Theme: githubtheme

tiago-marques avatar Feb 27 '18 18:02 tiago-marques

Thank you. If you would like to do a PR, that would be awesome. Otherwise I will look into it in the next days

thomaspink avatar Feb 28 '18 16:02 thomaspink

@thomaspink i dont have any experiences, but i could study and try on my free time. Thank you for the theme !

tiago-marques avatar Feb 28 '18 17:02 tiago-marques

Hey guys,

looks like the vscode tokenizer treats const declarations like readwrite variable declarations: https://github.com/Microsoft/TypeScript-TmLanguage/issues/542

Seems like we've got to be patient 😉

klausfischer avatar Mar 07 '18 20:03 klausfischer

Thanks @klausfischer

thomaspink avatar Mar 09 '18 10:03 thomaspink

@thomaspink @klausfischer Hi, thank you for the information. Can we found some solution for params colors and reserved words?

tiago-marques avatar Mar 09 '18 14:03 tiago-marques

Ping here because Microsoft/TypeScript-TmLanguage#542 has been closed. Maybe the theme needs some changes to take advantage of it?

albertorestifo avatar Jul 27 '18 08:07 albertorestifo

@albertorestifo i think this repo is archived. :(

tiago-marques avatar Jul 31 '18 13:07 tiago-marques