Thomas Constantine Moore

Results 46 comments of Thomas Constantine Moore

Will it be possible to get #3266 into the 2.0 release as well?

@weiznich yep, just double-checking! Auspicious timing...

Note that I'm happy to make this configurable if you'd like me to—but sometimes more configuration options aren't worth the hassle. Your call 🚀

note a similar PR in sqlx: https://github.com/launchbadge/sqlx/pull/2037/files

> Thanks for opening this PR. Diesel sets this option explicitly to maintain compatibility with other database systems. It might be possible to achieve such compatibility by generating different SQL...

@weiznich I might need some assistance on this. I've identified this implementation of the concat query fragment here in `expression/operators.rs`: ```rs impl QueryFragment for Concat where L: QueryFragment, R: QueryFragment,...

@weiznich I see that PR is Open—do I need to wait for it to be merged?

like it would be something like this? ```rs #[diesel_derives::__diesel_public_if( feature = "mysql" )] ``` ?

Well, that didn't work. Can you tell me what I'm doing wrong here?

Got it, let me see if I can make those adjustments...