thomasdn

Results 51 comments of thomasdn

I think the right way to present an album containing both images and sub albums is to present it with all the subalbums/folders first followed by all the images. Maybe...

> Yes, this choice was made (#343, #347, #348) to improve the maintenance of templates, and because this didn't seem to be a critical feature. Admittedly, I only took a...

Here is a suggestion on such a combined template: {% extends "base.html" %} {% block extra_head %} {% endblock extra_head %} {% block content %} {% if album.zip %} Download...

OK. So I looked a bit into the code for this. As I understand it, this is the code that produces the errors and also the code that decides to...

Do you agree with the above two ways of implementing this? Or is there a better way? Is it something you want to prioritize implementing? I would be happy to...

> Thanks for exploring the solutions, it seems you're on a good track. > > > Change AbstractWriter.writer so that it allows being passed both album and album.medias (as an...

I believe I have a working fix to this problem now. I have changed the album_list.html template in the gallaria. This works in the combination of theme='galleria' and galleria_theme='folio'. Here...

Please find this pull request with a new subtemplate 'album_items.html' that can be included in album_list.html and album.html. https://github.com/saimn/sigal/pull/438

@saimn you left a few comments on the pull request https://github.com/saimn/sigal/pull/438 to which I replied. This is the first time I do a pull request on github at all. So...

> Hi @thomasdn, > Sorry for not replying sooner, sigal as a toy project comes after almost everything else ;). > If you can just address the change about checking...