tech-dev-tooling icon indicating copy to clipboard operation
tech-dev-tooling copied to clipboard

Replace inherit with explicit secret passing

Open Amdrel opened this issue 1 year ago • 1 comments

Inherit won't work in our use-case. We have to pass OSS_SLACK_NOTIFICATION_WEBHOOK_URL explicitly for the job to use it properly.

Amdrel avatar Jun 14 '24 20:06 Amdrel

I could have sworn we discussed this in a huddle, but that inherit feature doesn't work with organization-level secrets if I recall correctly.

On Mon, Jun 17, 2024 at 11:39 AM Dustin Goodman @.***> wrote:

@.**** approved this pull request.

I'd love to understand why but this seems reasonable.

— Reply to this email directly, view it on GitHub https://github.com/thisdot/tech-dev-tooling/pull/54#pullrequestreview-2123652672, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA5XZXDMSCCD252OFCU4HDZH4UNRAVCNFSM6AAAAABJK6ZPFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRTGY2TENRXGI . You are receiving this because you authored the thread.Message ID: @.***>

Amdrel avatar Jun 18 '24 16:06 Amdrel