starter.dev icon indicating copy to clipboard operation
starter.dev copied to clipboard

[SvelteKit-pod]: fix: storybook

Open iansamz opened this issue 3 years ago • 3 comments

Type of change

  • [ ] Documentation change
  • [ ] Bug fix

Summary of change

Checklist

  • [ ] These changes follow the contributing guidelines
  • [ ] This starter kit has been approved by the maintainers
  • [ ] Changes for this new starter kit are being pushed to an integration branch instead of main
  • [ ] All dependencies are version locked
  • [ ] This fix resolves #
  • [ ] I have verified the fix works and introduces no further errors

iansamz avatar Dec 14 '22 14:12 iansamz

Deploy Preview for starter-dev canceled.

Name Link
Latest commit b2b6e19cec1f836cc0c591a159bf4922309e48c1
Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/6399f92cbdc3150008864eea

netlify[bot] avatar Dec 14 '22 14:12 netlify[bot]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-650.d2zmkukv1jdnvq.amplifyapp.com

When I tried to test this, I got these conflicting dep errors:

▶ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @storybook/[email protected]
npm ERR! Found: @storybook/[email protected]
npm ERR! node_modules/@storybook/svelte
npm ERR!   dev @storybook/svelte@"7.0.0-beta.6" from the root project
npm ERR!   @storybook/svelte@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/sveltekit
npm ERR!     dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!   1 more (@storybook/svelte-vite)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/svelte@">=6.4.20" from @storybook/[email protected]
npm ERR! node_modules/@storybook/addon-svelte-csf
npm ERR!   peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/sveltekit
npm ERR!     dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!   @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/svelte-vite
npm ERR!     @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/sveltekit
npm ERR!       dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @storybook/[email protected]
npm ERR! node_modules/@storybook/svelte
npm ERR!   peer @storybook/svelte@">=6.4.20" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/addon-svelte-csf
npm ERR!     peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/sveltekit
npm ERR!       dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!     @storybook/addon-svelte-csf@"^2.0.0" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/svelte-vite
npm ERR!       @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/[email protected]
npm ERR!       node_modules/@storybook/sveltekit
npm ERR!         dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/adambarrett/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/adambarrett/.npm/_logs/2022-12-14T15_53_26_834Z-debug-0.log

Do we need to do something here? Other than --force or --legacy-peer-deps I mean?

I believe there is a way to fix it let me find out

iansamz avatar Dec 15 '22 09:12 iansamz