starter.dev icon indicating copy to clipboard operation
starter.dev copied to clipboard

[express-apollo-prisma] Final cleanup from demo feedback

Open iansamz opened this issue 2 years ago • 3 comments

Type of change

  • [x] Documentation change
  • [x] Bug fix

Summary of change

  • [x] GraphQL naming conventions
  • [ ] Update README and link to accompanying blog post explaining limitations (Will be updated when blog is ready)
  • [x] Clean up the scripts (yarn start, yarn test etc)
  • [x] Fix linting issues (exclude .yaml files)
  • [x] .env globally available with running queue (optional)

Checklist

  • [ ] These changes follow the contributing guidelines
  • [ ] This starter kit has been approved by the maintainers
  • [ ] Changes for this new starter kit are being pushed to an integration branch instead of main
  • [ ] All dependencies are version locked
  • [ ] This fix resolves #1202
  • [ ] I have verified the fix works and introduces no further errors

iansamz avatar Mar 27 '23 12:03 iansamz

Deploy Preview for starter-dev canceled.

Name Link
Latest commit 414255ab89552572b4c60a9841ddc0693b9c394a
Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/642c3023ddc2af0008473d9c

netlify[bot] avatar Mar 27 '23 12:03 netlify[bot]

https://github.com/thisdot/starter.dev/blob/314dab55a7cadd757abdf16f5a8f0b6776bb4757/starters/express-apollo-prisma/src/graphql/mappers/technology.ts#L18-L18

Still refers to items

mbicknese avatar Mar 30 '23 07:03 mbicknese

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 04 '23 14:04 sonarqubecloud[bot]