queue icon indicating copy to clipboard operation
queue copied to clipboard

Bump target to iOS7, introduce nullability, always async, and separate storage from queue

Open gelosi opened this issue 9 years ago • 4 comments

Hi! Have a look please

I've updated README accordingly. Idea is:

  • introduce QueueJob to avoid direct using NSDictinary for creating jobs (plan to add to Job max retry times, expiration date, fire date, etc)
  • introduce nullability to prepare for Swift migration
  • decoupling storage from queue using EDQueuePersistentStorage brotocoli :)
  • adding some basic tests on top of that (to be continued)

gelosi avatar Feb 19 '16 15:02 gelosi

Very cool. Taking a look now.

thisandagain avatar Feb 19 '16 17:02 thisandagain

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

thisandagain avatar Feb 19 '16 18:02 thisandagain

Hi Andrew

Cool! Thank you for a quick feedback. This is a very start. I will try to offer some idea on 'built-in' persistent storage. As I suppose apps which using  already some sqlite wrapper different from FMDB might stay aside. That is my approach. Ideally - having ready-to go fmdb submodule (as default dependency). And reduce persistent storage interface requirements to CRUD :)

— RO

On Fri, Feb 19, 2016 at 7:04 PM, Andrew Sliwinski [email protected] wrote:

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

Reply to this email directly or view it on GitHub: https://github.com/thisandagain/queue/pull/22#issuecomment-186334292

gelosi avatar Feb 19 '16 18:02 gelosi

@thisandagain so, shaping better approach. Have a look, please.

gelosi avatar Feb 24 '16 00:02 gelosi